fix: Update attachLauncher to use options object for integration settings#29
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the launcher attachment logic to use an options object for integration settings by adding new optional flags "noFunctional" and "noTargeting".
- Added new properties in the test suite to validate the new options.
- Updated the launcher initialization in Rokt-Kit.js to merge the new options when attaching the launcher.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/src/tests.js | Added tests to verify that "noFunctional" and "noTargeting" are correctly set when provided, and omitted when not included. |
| src/Rokt-Kit.js | Updated attachLauncher to use an options object and propagate the integration name along with the new optional flags. |
Comments suppressed due to low confidence (1)
src/Rokt-Kit.js:63
- [nitpick] Consider renaming this variable to 'customIntegrationName' to clearly differentiate the raw custom flag value from the processed integration name computed by generateIntegrationName.
var integrationName = customFlags && customFlags['Rokt.integrationName'];
BrandonStalnaker
approved these changes
May 12, 2025
BrandonStalnaker
left a comment
BrandonStalnaker
left a comment
There was a problem hiding this comment.
Looks good to my inexperienced eyes (and Cursors)
rmi22186
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
noFunctionalandnoTargetingto createLauncher options.Testing Plan
Pass in
noFunctionalandnoTargetingvia the config object in a sample app